-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust regex for container metrics #1105
Conversation
Memory/disk might be shown as 0B initially.
We are still unsure if there is a "real" problem with container metrics. |
We think this is caused by a recent bump of https://pkg.go.dev/code.cloudfoundry.org/bytefmt . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We are fairly confident that the issue is arising from a bytefmt bump in cf CLI 8.7.10 that picked up this change. Accordingly, I'm going to look to merge this PR. Thanks @philippthun ! |
…y#1105) Adjusts container metrics regex to allow for `cf app` output to display `memory` and `disk` output in bytes. Fixes `windows` and `apps` suite failures. Previously, the cf CLI defaulted to `K`, `M`, or `G` as the units for those columns. However, cf CLI v7.7.10/v8.7.10 bumped `code.cloudfoundry.org/bytefmt` to include [this change](cloudfoundry/bytefmt@854d396), which now outputs `B` as the unit in certain circumstances. --------- Co-authored-by: Carson Long <12767276+ctlong@users.noreply.github.com> (cherry picked from commit a169a8b)
…y#1105) Adjusts container metrics regex to allow for `cf app` output to display `memory` and `disk` output in bytes. Fixes `windows` and `apps` suite failures. Previously, the cf CLI defaulted to `K`, `M`, or `G` as the units for those columns. However, cf CLI v7.7.10/v8.7.10 bumped `code.cloudfoundry.org/bytefmt` to include [this change](cloudfoundry/bytefmt@854d396), which now outputs `B` as the unit in certain circumstances. --------- Co-authored-by: Carson Long <12767276+ctlong@users.noreply.github.com>
Adjust regex that "extracts" container metrics from cf-cli output. Memory/disk might be shown as
0B
initially.Output from a failed CATS run: